[Be-devel] Patch to unique_name

Trent Lillehaugen tllilleh at yahoo.com
Sun May 18 02:31:33 BST 2008


I noticed a small problem with unique_name.  When there is only 1 bug it creates a unique name with only 1 char, otherwise it uses a minimum of 3 chars.  My patch removes the clamp check every time through the loop and just starts 'chars' at 3 instead.  This yields consistent results (in the case of 1 bug), and removes the redundant check each time through the loop.

BTW, I am new to using bzr so I hope this is the correct way to send a patch.

Trent Lillehaugen

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: trent at trent-lillehaugens-macbook.local-20080518011350-\
#   319nd5m5ih1panl3
# target_branch: file:///Users/trent/proj/be/be-upstream/
# testament_sha1: d9943c2de9349ac3a9d8a7f84e37854bd26ea20a
# timestamp: 2008-05-17 18:20:08 -0700
# base_revision_id: cjb at laptop.org-20080516192559-kjymn0ynuj0ri70h
# 
# Begin patch
=== modified file 'libbe/cmdutil.py'
--- libbe/cmdutil.py2006-04-04 23:46:25 +0000
+++ libbe/cmdutil.py2008-05-18 01:04:01 +0000
@@ -24,14 +24,12 @@
 import utility
 
 def unique_name(bug, bugs):
-    chars = 1
+    chars = 3
     for some_bug in bugs:
         if bug.uuid == some_bug.uuid:
             continue
         while (bug.uuid[:chars] == some_bug.uuid[:chars]):
             chars+=1
-        if chars < 3:
-            chars = 3
     return bug.uuid[:chars]
 
 class UserError(Exception):

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWSHunBcAAobfgEAQUWP//3IG
BIC////wUAVYvA6oO5qqSihIRUEhNM1J5tIjT00CTxNRkyGmhglSnqeFPSaeSepkAAAAAABKaIlP
JPU9Nqm1AHqAAND1NGgMYDQAADQAAAAABJEIyATSeRpTDQpvVNPKek9TT01HpqPS+nDRGT9ojRhh
UMmQ1omwFFHk2+rVYhnt3IIsib3NPI26BnqSQS0hriVTPZS6ZbU8LFectHJZE69dolO4jTlQ/j1c
r9JEVfTl7IPmTmKCzUqXRwdxcZ68MZWwwZITlVpUnPQUJgH7Mx6l7k0Tf04EctC0MEF64mx1p0J0
LQ3nOdhR+G2iEflY9QeYira5325234USi0SIPviIUuaDZCitMxEpXnmdpMAuV41rJynemsIgD2Jo
nsdh47iK/K6lvC9ko/zcIu9XQXnhnQiHMiX7+GqoGamsC7qZUWuGJlFC6XzVQ6IWqBgbu4Gq3s1D
NegIxjmcqlkTTV5mTlSkWlN9cSBIuVRALSgwpFnytxA3DbGES+qJUxY5C3oUyAUJBTC0pTUjwkkR
QTXyeeYRNSiZEbcU5UjrGiTlQyRWbKRMgRLiR1qyut8Qg9w2UGkZQBhbgNcVJhiIDSLEOQsiVhyJ
E+oahCJdpVMsisrRq47oFgVSPlBjSyIysNFGBkMixUcw1gPciB/A+9cUFj1iUwB7CJoYGxQm40i5
SyinDPhErMioq4tYMfRVECQZKQ+RMd6RKENhwiiFSkKUDoB0+nkEBjBkHmMjt1OhjWEH8DOAzQfx
YWvqzHQxIFY6i1QjPMmZjmasZ2GV7Z5pIQL4hsSKHEEmzGoduove/UXtTVwbG189UO5mtKARdPOe
MhZbeVD2BtCssJHPfMmfQ0zOnsXo7tg20DQOdXlSrSFQ6jFBH2Wl6gIf2XAxZgZAfPnuKjgcuh6K
AtxsQ6GHaQXy7UcbcakNCFZyAgngG8iYTMdZb/SSdC/VncLtG9ueXgTkMKFgpGqvN2ED1My8CpPS
JnKjKhhcJ0PwSHs3tu7w8Y5GWsjXwlGPeUPQciUovwGG9fYviLtu7azn4VaHwpCfu53iorkBM2QV
koGheL8DJDjSwp9bgKbQmOJAwBWJI10dpaWJjGBjdx9uGjleRTuMzwEhsQPcKY4mANqJiOaAkWZr
EJeSuDQTZHqgkHJeIPwXwHJCgGvuK/4v5ECRogMO5AQ3Vl9RdsuCwQreLJC9Wg+ztb1decJOVPZm
1oGUTEinFAYH3SXMKyUb0cgg80LrRlEO//T6F4RFtxLD3UTvXiVyPuyrTAG1FM9wrFWVDzyM6xEA
SUmFJkFydLs246pLTCiS0AmRZDJhHIjzPFGPUwAgN45LmCSvgPWGky+obBjcXHWipVgYLvVu0yYM
Pssep9gZWArDRA+7sX6BxJVCLj6meAyUFNW+SayCKUB4ZAQJBFgYXF+zZJQgTBhuwPwg4haupAYv
Uh6xSFe19pN3SXoHcDkAYA9S8YtLSom+WIbQDigxqVvWNUhjcjuPc7T0CFhAiYUyQSsiHn8UQKng
QzVwwVzHSgZ0OKFvJxeSHkhmM/8QstDecjZxyAhyS5rR01akWoP/F3JFOFCQIe6cFw==



      



More information about the Be-devel mailing list